Symlink batch ensembles and batch models #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankona
reviewed
Apr 17, 2024
ankona
reviewed
Apr 17, 2024
ankona
reviewed
Apr 17, 2024
ankona
reviewed
Apr 17, 2024
ankona
reviewed
Apr 17, 2024
tests/test_output_files.py
Outdated
| @@ -225,3 +230,40 @@ def test_symlink_error(test_dir): | |||
| bad_step = controller._create_job_step(bad_model, telem_dir) | |||
| with pytest.raises(FileNotFoundError): | |||
| controller.symlink_output_files(bad_step, bad_model) | |||
|
|
|||
|
|
|||
| def test_batch_model_and_ensemble(test_dir): | |||
There was a problem hiding this comment.
We have a lot of new conditionals above, so a single test doesn't seem adequate. If we can't test logic, we should definitely extract new methods that can be tested (e.g. the aforementioned if_this_thing_should_have_symlinks())
Consider adding tests to also verify that symlinks are not created when they shouldn't be.
added 9 commits
April 17, 2024 16:55
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #547 +/- ##
===========================================
+ Coverage 68.72% 71.55% +2.83%
===========================================
Files 65 66 +1
Lines 4559 4571 +12
===========================================
+ Hits 3133 3271 +138
+ Misses 1426 1300 -126
|
added 3 commits
April 19, 2024 14:22
ankona
pushed a commit
to ankona/SmartSim
that referenced
this pull request
May 6, 2024
After testing a bunch of batch ensembles and batch models, I found that I hadn't actually symlinked the substeps in the controller. This fix should properly symlink the substeps. [ committed by @AlyssaCote ] [ reviewed by @ankona ]
ankona
pushed a commit
to ankona/SmartSim
that referenced
this pull request
May 7, 2024
After testing a bunch of batch ensembles and batch models, I found that I hadn't actually symlinked the substeps in the controller. This fix should properly symlink the substeps. [ committed by @AlyssaCote ] [ reviewed by @ankona ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After testing a bunch of batch ensembles and batch models, I found that I hadn't actually symlinked the substeps in the controller. This fix should properly symlink the substeps.