Discontinue SmartSim support for python 3.8 #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
April 10, 2024 09:17
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #544 +/- ##
============================================
+ Coverage 69.44% 83.85% +14.40%
============================================
Files 65 65
Lines 4553 4553
============================================
+ Hits 3162 3818 +656
+ Misses 1391 735 -656
|
MattToast
approved these changes
Apr 16, 2024
amandarichardsonn
added
API break
amandarichardsonn
changed the title
ankona
pushed a commit
to ankona/SmartSim
that referenced
this pull request
May 6, 2024
Python 3.8 is nearing its end of life so we're no longer supporting it. [ committed by @AlyssaCote ] [ reviewed by @MattToast @mellis13 ]
ankona
pushed a commit
to ankona/SmartSim
that referenced
this pull request
May 7, 2024
Python 3.8 is nearing its end of life so we're no longer supporting it. [ committed by @AlyssaCote ] [ reviewed by @MattToast @mellis13 ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 is no longer going to be supported because it's near end of life. I've gone through and removed/updated everything that I could find! I added
no-mergebecause I am not sure if there's a specific order that we need to merge all the repos.