-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple authenticator and socket creation #542
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dragon_launcher #542 +/- ##
==================================================
Coverage ? 63.66%
==================================================
Files ? 75
Lines ? 5403
Branches ? 0
==================================================
Hits ? 3440
Misses ? 1963
Partials ? 0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throwing some initial feedback your way! In general I think the authenticator changes look good, but I noticed that this PR was also making some changes along side the launchers and the telemetry monitor that didn't look strictly related. Is there anyway we can break them out into their own PRs in case we need to roll one back?
runs = [Run.load_run(raw_run, exp_dir) for raw_run in runs] | ||
runs = [Run.load_run(raw_run, exp_dir, manifest_dict) for raw_run in runs] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how I feel about shallow copying runs
and exp_dir
out of manifest_dict
but then passing manifest_dict
around the everywhere alongside the copied data. Can we just pass around the manifest_dict
instead??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to give the deserialization the object it was working on but also let it see higher level context info when it needed to do something wacky, like change behavior if it's a dragon launcher. I didn't like sending is_dragon
all the way down, nor do I like the idea of having to add a launcher: str
param, then another later, etc...
I think I like switching to passing only the experiment. That achieves my goal but avoids passing the entire manifest around. What do you think of that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense to me, and resolves my "multiple parameters pointing to same data" complaint! Totally in favor!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending tests!! Thanks for cleaning this up!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L
G
T
M
zmq.Context.instance()
factory method. Replaced as needed.Dragon
library version, which included a breaking changing causing the swap fromTemplateProcess
toProcessTemplate