-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dragon Launcher Batch Job Support #541
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dragon_launcher #541 +/- ##
==================================================
Coverage ? 67.54%
==================================================
Files ? 78
Lines ? 5983
Branches ? 0
==================================================
Hits ? 4041
Misses ? 1942
Partials ? 0
|
@amandarichardsonn @mellis13 @ashao if you have time, can you take a look at the new docs sections? They are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job on the documentation! I will review the other contents of the PR but heres some feedback to get you started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than minor docstring nitpicks, this LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for making the doc changes!
This PR actually adds several things:
DragonBatchStep
with logic to keep track of batch jobs run through SLURM and PBSCONFIG
to help with launching dragon with optionsDragonBackend
to make sure telemetry monitor can get updates before it shuts downDragonBackend
status is now a string representation of two tables, one for hosts (indicating Free/Busy status) and one for ProcessGroups (similar to standard WLM output)