Application executes before colocated Orchestrator is created #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amandarichardsonn
added
area: orchestrator
mellis13
previously requested changes
Mar 15, 2024
There was a problem hiding this comment.
A couple of comments on the first round but want to wait for @ashao and @al-rigazzi feedback
This reverts commit 5fc34f0.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #522 +/- ##
===========================================
+ Coverage 90.67% 90.72% +0.04%
===========================================
Files 60 60
Lines 3817 3816 -1
===========================================
+ Hits 3461 3462 +1
+ Misses 356 354 -2
|
al-rigazzi
requested changes
Mar 20, 2024
ashao
previously requested changes
Mar 20, 2024
al-rigazzi
requested changes
Mar 21, 2024
There was a problem hiding this comment.
I suggest a small change to the filename, requesting @ashao's opinion on that too, to avoid too many iterations
al-rigazzi
reviewed
Mar 21, 2024
| filename = ( | ||
| f"{hostname}.log" | ||
| if os.getenv("SMARTSIM_LOG_LEVEL") == "debug" | ||
| else "/dev/null" |
There was a problem hiding this comment.
I also suggest "/dev/null" -> os.devnull see here as a more portable (and nice looking) solution.
There was a problem hiding this comment.
Good catch! would h8 for this to fail for others
al-rigazzi
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Orchestrator launch moved to a blocking process. Application executes once Orchestrator is built.