Correct ExecArgs Handling During RunSetting

smartsim/settings/base.py

@@ -121,7 +121,14 @@
 
     @exe_args.setter
     def exe_args(self, value: t.Union[str, t.List[str], None]) -> None:
-        self._exe_args = self._build_exe_args(value)
+        if (
+            isinstance(value, str)
+            or isinstance(value, list)
+            and all(isinstance(i, str) for i in value)
+        ):
+            self._exe_args = self._build_exe_args(value)
+        else:
+            raise TypeError("Executable arguments were not list of str or str.")
 
     @property
     def run_args(self) -> t.Dict[str, t.Union[int, str, float, None]]:
@@ -448,12 +455,16 @@
         :type args: str | list[str]
         :raises TypeError: if exe args are not strings
         """
+
+        if not isinstance(args, (list, str)):
+            raise TypeError("All elements in the list should be of type str")
+
         if isinstance(args, str):
             args = args.split()
 
-        for arg in args:
-            if not isinstance(arg, str):
-                raise TypeError("Executable arguments should be a list of str")
+        if isinstance(args, list):
+            if not all(isinstance(arg, str) for arg in args):
+                raise TypeError("All elements in the list should be of type str")
 
         self._exe_args.extend(args)
 
@@ -538,20 +549,7 @@
             if isinstance(exe_args, str):
                 return exe_args.split()
             if isinstance(exe_args, list):
-                exe_args = copy.deepcopy(exe_args)
-                plain_type = all(isinstance(arg, (str)) for arg in exe_args)
-                if not plain_type:
-                    nested_type = all(
-                        all(isinstance(arg, (str)) for arg in exe_args_list)
-                        for exe_args_list in exe_args
-                    )
-                    if not nested_type:
-                        raise TypeError(
-                            "Executable arguments were not list of str or str"
-                        )
-                    return exe_args
                 return exe_args
-            raise TypeError("Executable arguments were not list of str or str")
         return []
 
     def format_run_args(self) -> t.List[str]:

tests/test_run_settings.py

@@ -208,18 +208,17 @@ def test_add_exe_args_list_of_mixed_lists_init():
     exe_args = [["1", "2", 3], ["4", "5", 6]]
 
     with pytest.raises(TypeError) as type_error:
-        settings = RunSettings("python", exe_args=exe_args)
+        _ = RunSettings("python", exe_args=exe_args)
 
-    assert "Executable arguments were not list of str or str" in type_error.value.args
+    assert "Executable arguments were not list of str or str." in type_error.value.args
 
 
 def test_add_exe_args_list_of_str_lists_init():
     """Ensure that list[list[str]] pass validation"""
     exe_args = [["1", "2", "3"], ["4", "5", "6"]]
 
-    settings = RunSettings("python", exe_args=exe_args)
-
-    assert settings.exe_args == exe_args
+    with pytest.raises(TypeError) as type_error:
+        settings = RunSettings("python", exe_args=exe_args)
 
 
 def test_add_exe_args_list_of_str_lists():
@@ -323,6 +322,13 @@ def test_bad_exe_args_2():
         _ = RunSettings("python", exe_args=exe_args)
 
 
+def test_bad_exe_args_3():
+    """test when user provides incorrect types to exe_args"""
+    exe_args = [["this", "should"], ["not", "work"]]
+    with pytest.raises(TypeError):
+        _ = RunSettings("python", exe_args=exe_args)
+
+
 def test_set_args():
     rs = RunSettings("python")
     rs.set("str", "some-string")