Change generic t.any in Experiment API #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and get_status.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #501 +/- ##
========================================
Coverage 90.75% 90.75%
========================================
Files 60 60
Lines 3838 3838
========================================
Hits 3483 3483
Misses 355 355
|
MattToast
reviewed
Feb 26, 2024
amandarichardsonn
added
the
repo: smartsim
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
start,stop,generate, andget_statusAPI functions listt.anyas the type for*args. However, that is not specifically true, and underlying methods likeController.start()specifyt.Union[SmartSimEntity, EntitySequence[SmartSimEntity]]. This PR updates the typing on theExperimentAPI functions to reflect internal API requirements.