Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot Fix: bump dependency version #493

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Conversation

MattToast
Copy link
Member

@MattToast MattToast commented Feb 16, 2024

A critical performance concern was identified and addressed in SmartRedis. A patch fix was deployed, and SmartSim was updated to ensure users do not inadvertently pull the unpatched version of SmartRedis.

@MattToast MattToast requested a review from ashao February 16, 2024 02:24
@MattToast MattToast self-assigned this Feb 16, 2024
@MattToast MattToast added bug: critical A critical bug area: third-party Issues related to Issues related to dependencies and third-part and third-party package integrations labels Feb 16, 2024
Copy link
Member

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c043d2) 90.85% compared to head (9752c87) 90.85%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #493   +/-   ##
========================================
  Coverage    90.85%   90.85%           
========================================
  Files           60       60           
  Lines         3826     3826           
========================================
  Hits          3476     3476           
  Misses         350      350           

@ashao ashao merged commit 5444927 into CrayLabs:develop Feb 16, 2024
34 checks passed
@MattToast MattToast deleted the dep-hot-fix branch March 29, 2024 17:14
@amandarichardsonn amandarichardsonn added the repo: smartsim Issues related to SmartSim infrastructure library label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: third-party Issues related to Issues related to dependencies and third-part and third-party package integrations bug: critical A critical bug repo: smartsim Issues related to SmartSim infrastructure library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants