Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest: has DB objects refactor #476

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

MattToast
Copy link
Member

Refactor logic of Manifest.has_db_objects to remove excess branching and improve readability/maintainability.

Refactor logic of `Manifest.has_db_objects` to remove excess branching
and improve readability/maintainability.
@MattToast MattToast added the type: refactor Issues focused on refactoring existing code label Feb 6, 2024
@MattToast MattToast requested a review from ankona February 6, 2024 17:48
@MattToast MattToast self-assigned this Feb 6, 2024
Copy link
Contributor

@ankona ankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a4e828) 90.77% compared to head (86ff834) 85.31%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #476      +/-   ##
===========================================
- Coverage    90.77%   85.31%   -5.46%     
===========================================
  Files           60       60              
  Lines         3837     3821      -16     
===========================================
- Hits          3483     3260     -223     
- Misses         354      561     +207     
Files Coverage Δ
smartsim/_core/control/manifest.py 96.52% <100.00%> (+0.27%) ⬆️

... and 20 files with indirect coverage changes

@MattToast MattToast merged commit b84b49f into CrayLabs:develop Feb 6, 2024
34 checks passed
@MattToast MattToast deleted the has-db-obj-refactor branch February 6, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor Issues focused on refactoring existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants