Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate DBModel/Script prevention #475

Merged
merged 6 commits into from
Feb 12, 2024

Conversation

amandarichardsonn
Copy link
Contributor

@amandarichardsonn amandarichardsonn commented Feb 5, 2024

This PR prevents duplicate ML models and scripts names being added to an Ensemble member if the names exists already.
The checks are performed for Ensemble.add_ml_model(), Ensemble.add_model(), Ensemble.add_script() and Ensemble.add_function().

@amandarichardsonn amandarichardsonn changed the title pushing fix Duplicate DBModel/Script prevention Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (18fe50a) 90.55% compared to head (4bcdc4d) 90.74%.
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #475      +/-   ##
===========================================
+ Coverage    90.55%   90.74%   +0.19%     
===========================================
  Files           60       60              
  Lines         3821     3826       +5     
===========================================
+ Hits          3460     3472      +12     
+ Misses         361      354       -7     
Files Coverage Δ
smartsim/entity/ensemble.py 99.25% <100.00%> (+0.04%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small change requests but nothing worth holding up approval over! LGTM!!

smartsim/entity/ensemble.py Outdated Show resolved Hide resolved
smartsim/entity/ensemble.py Outdated Show resolved Hide resolved
tests/backends/test_dbmodel.py Outdated Show resolved Hide resolved
tests/backends/test_dbmodel.py Show resolved Hide resolved
@amandarichardsonn amandarichardsonn merged commit bbce88a into CrayLabs:develop Feb 12, 2024
34 checks passed
@amandarichardsonn amandarichardsonn deleted the duplicate branch February 12, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants