Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isort/black check to github actions #464

Merged
merged 8 commits into from
Jan 25, 2024

Conversation

amandarichardsonn
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4d1646) 90.75% compared to head (b7817d9) 90.46%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #464      +/-   ##
===========================================
- Coverage    90.75%   90.46%   -0.29%     
===========================================
  Files           60       60              
  Lines         3830     3829       -1     
===========================================
- Hits          3476     3464      -12     
- Misses         354      365      +11     
Files Coverage Δ
smartsim/_core/control/controller.py 86.88% <100.00%> (-0.33%) ⬇️
smartsim/_core/control/manifest.py 93.75% <100.00%> (-2.50%) ⬇️
smartsim/entity/dbobject.py 65.13% <100.00%> (ø)
smartsim/log.py 93.63% <100.00%> (ø)

... and 5 files with indirect coverage changes

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One super small change request, but otherwise LGTM!! Thanks for making sure that we keep our style black compliant!

.github/workflows/run_tests.yml Outdated Show resolved Hide resolved
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! LGTM pending tests!!

@amandarichardsonn amandarichardsonn merged commit 50aa382 into CrayLabs:develop Jan 25, 2024
34 checks passed
@amandarichardsonn amandarichardsonn deleted the black-isort-ci branch January 25, 2024 23:19
ashao pushed a commit to ashao/SmartSim that referenced this pull request Jan 30, 2024
This PR merges in github actions for running checks - black and isort

[ reviewed by @MattToast ]
[ committed by @amandarichardsonn ]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants