Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override sphinx-tabs background color #453

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

mellis13
Copy link
Contributor

The sphinx-tabs documentation extension uses a white background for the tabs component. This causes readability issues with the theme that we have chosen. This PR overrides the CSS for those components to inherit the overall theme color.

body color to improve text readability.
@mellis13 mellis13 added the area: docs Issues related to documentation label Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f3a9a1) 90.07% compared to head (68d4fa4) 90.47%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #453      +/-   ##
===========================================
+ Coverage    90.07%   90.47%   +0.40%     
===========================================
  Files           60       60              
  Lines         3738     3738              
===========================================
+ Hits          3367     3382      +15     
+ Misses         371      356      -15     

see 7 files with indirect coverage changes

Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for looking into this!

@mellis13 mellis13 merged commit 9e550a8 into CrayLabs:develop Jan 10, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants