Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references in docs to nonexistent CLI flag #358

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Remove references in docs to nonexistent CLI flag #358

merged 1 commit into from
Sep 8, 2023

Conversation

MattToast
Copy link
Member

Remove references in the docs to the (now invalid) --only_python_pacakges flag of smart build

@MattToast MattToast added the area: docs Issues related to documentation label Sep 8, 2023
@MattToast MattToast requested a review from ashao September 8, 2023 00:32
@MattToast MattToast self-assigned this Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited
Loading

Codecov Report

Merging #358 (d30c473) into develop (96305f2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #358   +/-   ##
========================================
  Coverage    88.43%   88.43%           
========================================
  Files           59       59           
  Lines         3580     3580           
========================================
  Hits          3166     3166           
  Misses         414      414

📢 Thoughts on this report? Let us know!.

ashao
ashao approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that! Especially like the fact that you actually call out to smart build --help now so that we don't have to remember to manually touch this in the future.

@MattToast MattToast merged commit b459bf2 into CrayLabs:develop Sep 8, 2023
10 checks passed
@MattToast MattToast deleted the rm-only-python-pkg-flag-refs branch September 11, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashao ashao ashao approved these changes

Assignees

@MattToast MattToast

Labels
area: docs Issues related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattToast @ashao