Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smart validate should not hang when error in TF process #351

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

MattToast
Copy link
Member

Closes an unneeded mp.Connection causing smart to hang.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #351 (93c2653) into develop (90ba36e) will increase coverage by 0.11%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #351      +/-   ##
===========================================
+ Coverage    88.34%   88.45%   +0.11%     
===========================================
  Files           59       59              
  Lines         3552     3552              
===========================================
+ Hits          3138     3142       +4     
+ Misses         414      410       -4     

see 1 file with indirect coverage changes

Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM

@MattToast MattToast assigned MattToast and unassigned al-rigazzi Aug 28, 2023
@MattToast MattToast merged commit 9c31c86 into CrayLabs:develop Aug 28, 2023
10 checks passed
@MattToast MattToast deleted the validate-no-hang branch September 11, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: minor A minor bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants