Add support for Slurm heterogeneous jobs #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al-rigazzi
added
area: settings
ashao
approved these changes
Aug 23, 2023
ashao
reviewed
Aug 23, 2023
smartsim/settings/slurmSettings.py
Outdated
| @@ -270,6 +274,17 @@ def set_walltime(self, walltime: str) -> None: | |||
| """ | |||
| self.run_args["time"] = str(walltime) | |||
|
|
|||
| def set_het_group(self, het_group: int) -> None: | |||
There was a problem hiding this comment.
One other thought that I just had. Thrown an error here and also in make_mpmd in case someone tries to set a het_group and also mpmd at the same time.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #346 +/- ##
========================================
Coverage 87.04% 87.04%
========================================
Files 59 59
Lines 3551 3551
========================================
Hits 3091 3091
Misses 460 460
|
MattToast
requested changes
Aug 24, 2023
Co-authored-by: Matt Drozt <matthew.drozt@gmail.com>
Co-authored-by: Matt Drozt <matthew.drozt@gmail.com>
MattToast
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds (limited) support for Slurm heterogeneous jobs. Basically, het jobs overload the syntax used by MPMD workloads, and this can be the cause of problems when running on Slurm. This PR adds several checks to see if the allocation is heterogeneous and prevents the user from running MPMD models (or
single_cmdorchestrators).Still missing: