Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing changelog entries #345

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Add missing changelog entries #345

merged 1 commit into from
Aug 23, 2023

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Aug 23, 2023

Update changelog for PRs previously merged (334, 338, 341)

@ankona ankona requested a review from MattToast August 23, 2023 15:36
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #345 (a432c39) into develop (154f19c) will decrease coverage by 0.32%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #345      +/-   ##
===========================================
- Coverage    87.15%   86.84%   -0.32%     
===========================================
  Files           59       59              
  Lines         3551     3549       -2     
===========================================
- Hits          3095     3082      -13     
- Misses         456      467      +11     

see 4 files with indirect coverage changes

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Looks like the CI is just eating it on uploading to CodeCov so this LGTM!!

@ankona ankona merged commit 092c0ec into CrayLabs:develop Aug 23, 2023
5 of 10 checks passed
@MattToast MattToast added the area: docs Issues related to documentation label Sep 13, 2023
@ankona ankona deleted the docs branch June 3, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants