Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raising error for reserved keywords under function parameter options in get_allocation #325

Merged
merged 25 commits into from
Jul 31, 2023

Commits on Jul 20, 2023

  1. tests in test_slurm_allocation and error check in slurm

    Julia Putko authored and Julia Putko committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    419df86 View commit details
    Browse the repository at this point in the history
  2. corrected test to dict

    Julia Putko authored and Julia Putko committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    e0b6320 View commit details
    Browse the repository at this point in the history
  3. removed stuff after it fails out in test

    Julia Putko authored and Julia Putko committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    53a8173 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. parameterized tests

    Julia Putko authored and Julia Putko committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    53cba50 View commit details
    Browse the repository at this point in the history
  2. naming edit

    Julia Putko authored and Julia Putko committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    f12c455 View commit details
    Browse the repository at this point in the history
  3. Whitespace removal, removed unused params, and changed error raised t…

    …o ValueError
    Julia Putko authored and Julia Putko committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    081e8c8 View commit details
    Browse the repository at this point in the history
  4. raising correct error in test

    Julia Putko authored and Julia Putko committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    0ba0cbb View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. removed unused error

    Julia Putko authored and Julia Putko committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    965a8b4 View commit details
    Browse the repository at this point in the history
  2. removed whitespace

    Julia Putko authored and Julia Putko committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    8f7a745 View commit details
    Browse the repository at this point in the history
  3. deleting test that allows bad behaviour

    Julia Putko authored and Julia Putko committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    3b89865 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. checking to make sure error is correctly thrown

    Julia Putko authored and Julia Putko committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    9863cd1 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. removed unused

    Julia Putko authored and Julia Putko committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    c491dc1 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. added validation before loop, and improved test

    Julia Putko authored and Julia Putko committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    4a189e0 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'develop' of github.com:CrayLabs/SmartSim into jp116

    Julia Putko authored and Julia Putko committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    8c90c7c View commit details
    Browse the repository at this point in the history
  3. typo on intersection

    Julia Putko authored and Julia Putko committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    1934e0a View commit details
    Browse the repository at this point in the history
  4. test

    Julia Putko authored and Julia Putko committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    8926464 View commit details
    Browse the repository at this point in the history
  5. typo

    Julia Putko authored and Julia Putko committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    86ae6c9 View commit details
    Browse the repository at this point in the history
  6. fixing mypy error

    Julia Putko authored and Julia Putko committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    937e18e View commit details
    Browse the repository at this point in the history
  7. black line length fixing

    Julia Putko authored and Julia Putko committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e4f6870 View commit details
    Browse the repository at this point in the history
  8. lint error fix

    Julia Putko authored and Julia Putko committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    80d56af View commit details
    Browse the repository at this point in the history
  9. lint error fix

    Julia Putko authored and Julia Putko committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    64bff4f View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. removed TODO

    Julia Putko authored and Julia Putko committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    218b1b1 View commit details
    Browse the repository at this point in the history
  2. added new/more accurate error

    Julia Putko authored and Julia Putko committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    695982d View commit details
    Browse the repository at this point in the history
  3. cleaned lint

    Julia Putko authored and Julia Putko committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    2adba67 View commit details
    Browse the repository at this point in the history
  4. changed parent for error

    Julia Putko authored and Julia Putko committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    295ae72 View commit details
    Browse the repository at this point in the history