Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove requirements(-*).txt and update docs #307

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Jun 22, 2023

  • Delete requirements.txt, requirements-dev.txt, requirements-mypy.txt
  • Remove requirements.txt from manifest.in
  • Update installation instructions in docs to use setup.py

@ankona ankona requested a review from mellis13 June 22, 2023 15:18
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #307 (a27ba45) into develop (0ddf7b3) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #307   +/-   ##
========================================
  Coverage    87.54%   87.54%           
========================================
  Files           59       59           
  Lines         3461     3461           
========================================
  Hits          3030     3030           
  Misses         431      431           

Copy link
Contributor

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this long overdue change. LGTM!

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small clarifications requested

doc/developer.rst Outdated Show resolved Hide resolved
doc/testing.rst Outdated Show resolved Hide resolved
@ankona ankona requested a review from MattToast June 22, 2023 21:21
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ankona ankona merged commit e6e563a into CrayLabs:develop Jun 23, 2023
@ankona ankona deleted the oss180 branch June 28, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants