Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add internal API typehints #303

Merged
merged 82 commits into from
Jun 22, 2023
Merged

Add internal API typehints #303

merged 82 commits into from
Jun 22, 2023

Commits on Jun 13, 2023

  1. internal typehints batch 1

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    a0ecd55 View commit details
    Browse the repository at this point in the history

  2. convert returncode to int type

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    c6d22e5 View commit details
    Browse the repository at this point in the history

  3. omit/fix from batch 1

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    34b4146 View commit details
    Browse the repository at this point in the history

  4. typehints batch 2

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    66df566 View commit details
    Browse the repository at this point in the history

  5. typehints batch 3

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    b13efc4 View commit details
    Browse the repository at this point in the history

  6. local launcher typehints

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    2799edf View commit details
    Browse the repository at this point in the history

  7. lsf/pbs/slurm launcher typehints

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    89db941 View commit details
    Browse the repository at this point in the history

  8. error typehints

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    f4a07f2 View commit details
    Browse the repository at this point in the history

  9. typehints batch 4, generator & friends

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    66c86ea View commit details
    Browse the repository at this point in the history

  10. typehints batch 5, control, entrypoints, generator, utils

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    034a598 View commit details
    Browse the repository at this point in the history

  11. jobmanager typehints

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    f6c341e View commit details
    Browse the repository at this point in the history

  12. job/jobmanager typehints 2

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    d8d416c View commit details
    Browse the repository at this point in the history

  13. DANGER: typehints for controller and everything it touches

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    5f9c3b7 View commit details
    Browse the repository at this point in the history

  14. _core.config typehints fixes

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    10e3db6 View commit details
    Browse the repository at this point in the history

  15. smartsim.settings typehints

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    29ec4f5 View commit details
    Browse the repository at this point in the history

  16. smarsim.ml.data typehints

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    c0d30bb View commit details
    Browse the repository at this point in the history

  17. tf.data, tf.utils typehints

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    8066b0a View commit details
    Browse the repository at this point in the history

  18. ml.torch typehint start

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    7e2ba5b View commit details
    Browse the repository at this point in the history

  19. _core.utils.redis type ignore

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    415dff7 View commit details
    Browse the repository at this point in the history

  20. ml.torch fix incorrect null check for typehinted nullable

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    24b6d48 View commit details
    Browse the repository at this point in the history

  21. Reverse mypy config to blacklist instead of whitelist

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    2d65d29 View commit details
    Browse the repository at this point in the history

  22. undo incorrect redis conf merge

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    f74afac View commit details
    Browse the repository at this point in the history

  23. fix t.List[ vs list[ bugs

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    8267319 View commit details
    Browse the repository at this point in the history

  24. fix another t.List issue

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    aebe3a1 View commit details
    Browse the repository at this point in the history

  25. Update changelog notes for typehints

    @ankona
    ankona committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    e5c2682 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. minor fixes per review comments

    @ankona
    ankona committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    d94e7b0 View commit details
    Browse the repository at this point in the history

  2. comment & docstring cleanup

    @ankona
    ankona committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    79d1fe4 View commit details
    Browse the repository at this point in the history

  3. tighten base class / concrete class usage in Steps

    @ankona
    ankona committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    6e3ca14 View commit details
    Browse the repository at this point in the history

  4. Revert some optional args for consistency/clarity

    @ankona
    ankona committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    f0f1f63 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Merge remote-tracking branch 'upstream/develop' into typehints22

    @ankona
    ankona committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    896e80d View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. use literal for db engine name args

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    38f9217 View commit details
    Browse the repository at this point in the history

  2. fix dict value typehint

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    64ddd77 View commit details
    Browse the repository at this point in the history

  3. _core._cli, _core._install typehints

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    6ab6745 View commit details
    Browse the repository at this point in the history

  4. fix formatting per review

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    f34bfd1 View commit details
    Browse the repository at this point in the history

  5. tweak changelog formatting to avoid bad html gen

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    91ac505 View commit details
    Browse the repository at this point in the history

  6. fix unnecessary casting per review

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    42a4ac9 View commit details
    Browse the repository at this point in the history

  7. swap comparison operators from object to t.Any

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    67744df View commit details
    Browse the repository at this point in the history

  8. remove local launcher check from loop

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    e0bb920 View commit details
    Browse the repository at this point in the history

  9. Fix incorrect error text

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    22106c6 View commit details
    Browse the repository at this point in the history

  10. reduce cyclomatic complexity

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    2d3153c View commit details
    Browse the repository at this point in the history

  11. fix version rename bug

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    aede87e View commit details
    Browse the repository at this point in the history

  12. update incorrect docstring

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    0d1c6b2 View commit details
    Browse the repository at this point in the history

  13. remove extraneous null check

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    cf60661 View commit details
    Browse the repository at this point in the history

  14. treat job id as str

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    3d7803b View commit details
    Browse the repository at this point in the history

  15. Fix incorrect rtype on signal handlers

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    252be6c View commit details
    Browse the repository at this point in the history

  16. Remove deprecated type check

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    17fd40a View commit details
    Browse the repository at this point in the history

  17. fix docstring drift

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    982c3a7 View commit details
    Browse the repository at this point in the history

  18. fix docstring drift

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    af40410 View commit details
    Browse the repository at this point in the history

  19. Adjust entityfiles null handling

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    5a53cf7 View commit details
    Browse the repository at this point in the history

  20. tighten t.Any to str

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    85f4a0a View commit details
    Browse the repository at this point in the history

  21. avoid nullable return value

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    0559f53 View commit details
    Browse the repository at this point in the history

  22. tweak to return non-nullable string

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    a406746 View commit details
    Browse the repository at this point in the history

  23. avoid indent, reduce cyclomatic complexity

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    4d2995e View commit details
    Browse the repository at this point in the history

  24. Avoid deprecated abstractproperty

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    01fe78b View commit details
    Browse the repository at this point in the history

  25. Remove no-op __init__

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    315de9b View commit details
    Browse the repository at this point in the history

  26. Remove old "unassigned" default value for step_id

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    8189eac View commit details
    Browse the repository at this point in the history

  27. formatting fix

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    e627744 View commit details
    Browse the repository at this point in the history

  28. remove empty trailing comment

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    bb63a34 View commit details
    Browse the repository at this point in the history

  29. tighten set typehint

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    09db3b1 View commit details
    Browse the repository at this point in the history

  30. fix formatting

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    ea10b5b View commit details
    Browse the repository at this point in the history

  31. avoid unnecessary t.Union

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    0be9bb4 View commit details
    Browse the repository at this point in the history

  32. rename for internal method

    @ankona
    ankona committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    71508c2 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. fix variable re-definition

    @ankona
    ankona committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    80f2567 View commit details
    Browse the repository at this point in the history

  2. raise runtime error when bash not found

    @ankona
    ankona committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    28394e3 View commit details
    Browse the repository at this point in the history

  3. Add missing run_settings property

    @ankona
    ankona committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    0abdb5f View commit details
    Browse the repository at this point in the history

  4. Make step_settings arg non-nullable in Step init

    @ankona
    ankona committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    c29ee21 View commit details
    Browse the repository at this point in the history

  5. clean up _get_smartsim_status duplication, move mapping to StepInfo prop

    @ankona
    ankona committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    747d4fc View commit details
    Browse the repository at this point in the history

  6. narrow typehint for env dictionary

    @ankona
    ankona committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    7e33065 View commit details
    Browse the repository at this point in the history

  7. tighten generics typehints

    @ankona
    ankona committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    3add880 View commit details
    Browse the repository at this point in the history

  8. remove unnecessary hint

    @ankona
    ankona committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    0bd1097 View commit details
    Browse the repository at this point in the history

  9. remove extraneous coalesce

    @ankona
    ankona committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    83b8680 View commit details
    Browse the repository at this point in the history

  10. Add cluster hint back in

    @ankona
    ankona committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    20a3bbf View commit details
    Browse the repository at this point in the history

  11. separate installation check for clarity

    @ankona
    ankona committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    c924c57 View commit details
    Browse the repository at this point in the history

  12. simplify backend install check return value

    @ankona
    ankona committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    8eb4392 View commit details
    Browse the repository at this point in the history

  13. avoid None|int|str input to int(...)

    @ankona
    ankona committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    11066ba View commit details
    Browse the repository at this point in the history

  14. docstring fixes

    @ankona
    ankona committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    529cc9d View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Fix incorrect typehint on container arguments

    @ankona
    ankona committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    664e676 View commit details
    Browse the repository at this point in the history

  2. Fix bug excluding default singularity cmd string

    @ankona
    ankona committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    5710ad7 View commit details
    Browse the repository at this point in the history

  3. Fix circular import for container

    @ankona
    ankona committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    03192d8 View commit details
    Browse the repository at this point in the history

  4. Use property to avoid repetitive null checks

    @ankona
    ankona committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    89a1e94 View commit details
    Browse the repository at this point in the history

  5. remove unnecessary hint following isinstance

    @ankona
    ankona committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    f6b3586 View commit details
    Browse the repository at this point in the history

  6. Tweak _build_run_settings_lsf for non-nullable LSF make_mpmd argument

    @ankona
    ankona committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    fa9db5c View commit details
    Browse the repository at this point in the history