Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better test port usage clean up #302

Closed

Conversation

MattToast
Copy link
Member

Fix a test that can leak an orc using a port

@MattToast MattToast added the area: test Issues related to the test suite label Jun 7, 2023
@MattToast MattToast requested a review from mellis13 June 7, 2023 23:18
@MattToast MattToast self-assigned this Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #302 (5b23800) into develop (d4f7df8) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #302   +/-   ##
========================================
  Coverage    87.64%   87.64%           
========================================
  Files           58       58           
  Lines         3319     3319           
========================================
  Hits          2909     2909           
  Misses         410      410           

@MattToast
Copy link
Member Author

Problem was reproduced despite this change, this appears to be a rehearing. Closing as an unnecessary change.

@MattToast MattToast closed this Jun 8, 2023
@MattToast MattToast deleted the fix-test-not-cleaning-up-port branch June 8, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: test Issues related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant