Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wait associated with Experiment start summary #298

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Remove wait associated with Experiment start summary #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d8df0d
Remove wait associated with Experiment.start(summary=true).
mellis13 Jun 5, 2023
f8f61f0
Update changelog
mellis13 Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ Description

A full list of changes and detailed notes can be found below:

- Remove wait time associated with Experiment launch summary
- Update and rename Redis conf file
- Migrate from redis-py-cluster to redis-py
- Update full test suite to not require a TF wheel at test time
Expand All @@ -36,6 +37,7 @@ A full list of changes and detailed notes can be found below:

Detailed notes

- Remove wait time associated with Experiment launch summary (PR298_)
- Update Redis conf file to conform with Redis v7.0.5 conf file (PR293_)
- Migrate from redis-py-cluster to redis-py for cluster status checks (PR292_)
- Update full test suite to no longer require a tensorflow wheel to be available
Expand All @@ -51,6 +53,7 @@ codes. These have now all been updated. (PR284_)
- Orchestrator and Colocated DB now accept a list of interfaces to bind to. The
argument name is still `interface` for backward compatibility reasons. (PR281_)

.. _PR298: https://github.com/CrayLabs/SmartSim/pull/298
.. _PR293: https://github.com/CrayLabs/SmartSim/pull/293
.. _PR292: https://github.com/CrayLabs/SmartSim/pull/292
.. _PR291: https://github.com/CrayLabs/SmartSim/pull/291
Expand Down
12 changes: 0 additions & 12 deletions smartsim/experiment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,17 +814,5 @@ def _launch_summary(self, manifest):

logger.info(summary)

wait, steps = 10, 100
prog_bar = trange(
steps,
desc="Launching in...",
leave=False,
ncols=80,
mininterval=0.25,
bar_format="{desc}: {bar}| {remaining} {elapsed}",
)
for _ in prog_bar:
time.sleep(wait / steps)

def __str__(self):
return self.name