Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typehints #295

Merged
merged 45 commits into from
Jun 8, 2023
Merged

Typehints #295

merged 45 commits into from
Jun 8, 2023

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Jun 1, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #295 (0739ee6) into develop (d4f7df8) will increase coverage by 0.08%.
The diff coverage is 96.52%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #295      +/-   ##
===========================================
+ Coverage    87.64%   87.72%   +0.08%     
===========================================
  Files           58       59       +1     
  Lines         3319     3390      +71     
===========================================
+ Hits          2909     2974      +65     
- Misses         410      416       +6     
Impacted Files Coverage Δ
smartsim/entity/entityList.py 92.85% <85.71%> (-7.15%) ⬇️
smartsim/database/orchestrator.py 83.33% <87.09%> (+0.12%) ⬆️
smartsim/entity/dbnode.py 66.66% <88.23%> (+0.62%) ⬆️
smartsim/entity/model.py 96.39% <90.00%> (-0.75%) ⬇️
smartsim/experiment.py 79.85% <95.00%> (+<0.01%) ⬆️
smartsim/_core/control/controller.py 84.66% <100.00%> (+0.21%) ⬆️
smartsim/_core/control/job.py 93.15% <100.00%> (+0.09%) ⬆️
smartsim/_core/control/manifest.py 94.82% <100.00%> (+0.04%) ⬆️
smartsim/_core/generation/generator.py 93.75% <100.00%> (+0.20%) ⬆️
smartsim/_core/launcher/colocated.py 93.25% <100.00%> (+0.15%) ⬆️
... and 24 more

pyproject.toml Outdated Show resolved Hide resolved
requirements-dev.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@billschereriii billschereriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small questions, but the vast majority of this PR looks really good. Thanks for all the hard work!

@ankona ankona marked this pull request as ready for review June 5, 2023 20:25
Copy link
Contributor

@billschereriii billschereriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for all your hard work on this one.
Btw, I really like the recent change of defining type alias names for come of the more complex types. We should replicate that elsewhere as it makes sense to do so to take advantage of the readability gains it provides

@ankona ankona merged commit 395ffb0 into CrayLabs:develop Jun 8, 2023
@ankona ankona deleted the typehints branch June 28, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants