Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the MacOSX runner image version #285

Merged
merged 5 commits into from
May 11, 2023

Conversation

ashao
Copy link
Member

@ashao ashao commented May 9, 2023

We had pinned the MacOS X runner image to 10.15. This particular image on Github Actions began deprecation in May 2022. The runner itself is now no longer available and so all MacOS X Github actions are timing. This bumps the version to the latest image macos-12

@ashao ashao requested a review from ankona May 9, 2023 21:42
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #285 (93f6420) into develop (9227e24) will increase coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #285      +/-   ##
===========================================
+ Coverage    87.52%   87.58%   +0.05%     
===========================================
  Files           60       60              
  Lines         3374     3374              
===========================================
+ Hits          2953     2955       +2     
+ Misses         421      419       -2     

see 1 file with indirect coverage changes

@ashao ashao added the area: CI/CD Issues related to continuous integration and deployment label May 9, 2023
- Orchestrator and Colocated DB now accept a list of interfaces to bind to. The argument name is still `interface`
for backward compatibility reasons. (PR281_)

.. _PR285: https://github.com/CrayLabs/SmartSim/pull/285
.. _PR281: https://github.com/CrayLabs/SmartSim/pull/282
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is not part of your PR, but _PR281 points to .../282. Could you fix it (aka could you correct my mistake)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this refers to the line below the one you added)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do!

Copy link
Contributor

@billschereriii billschereriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashao ashao merged commit 1df7b53 into CrayLabs:develop May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI/CD Issues related to continuous integration and deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants