Drop ray support and delete references in docs #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## develop #263 +/- ##
===========================================
+ Coverage 84.06% 84.95% +0.89%
===========================================
Files 62 60 -2
Lines 3545 3424 -121
===========================================
- Hits 2980 2909 -71
+ Misses 565 515 -50
|
MattToast
approved these changes
Feb 28, 2023
doc/changelog.rst
Outdated
| @@ -38,6 +39,9 @@ Detailed Notes | |||
| satisfied, the `Experiment` will attempt to wrap the underlying run command in a batch job using | |||
| the object referenced at `Model.batch_settings` as the batch settings for the job. If the check | |||
| is not satisfied, the `Model` is launched in the traditional manner as a job step. (PR245_) | |||
| - The support for Ray was dropped, as its most recent versions caused problems when deployed through SmartSim. | |||
| We plan to release a separate add-on library to accomplish the same results. If | |||
| you are interested in getting the Ray launch functionality back in your workflow, please get in touch with us! | |||
There was a problem hiding this comment.
Just following the pattern of the changelog.rst, should we link this PR here?
There was a problem hiding this comment.
Totally, I did not have the link until it was published :)
Fix changelog order and links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the Ray Cluster feature from SmartSim. This includes: