Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set number of tasks for PALS mpiexec #247

Merged
merged 6 commits into from
Jan 18, 2023
Merged

Conversation

rickybalin
Copy link
Contributor

Added an explicit call to set the number of tasks for the PALS mpiexec settings. This now sets the number of tasks with "--np", whereas before it was being set with "--n", which was giving and error on Polaris.

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #247 (dd67114) into develop (ff2cf24) will decrease coverage by 0.18%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #247      +/-   ##
===========================================
- Coverage    83.90%   83.72%   -0.19%     
===========================================
  Files           59       62       +3     
  Lines         3479     3514      +35     
===========================================
+ Hits          2919     2942      +23     
- Misses         560      572      +12     
Impacted Files Coverage Δ
smartsim/settings/palsSettings.py 87.50% <50.00%> (-1.64%) ⬇️
smartsim/__init__.py 100.00% <0.00%> (ø)
smartsim/tf/utils.py 26.66% <0.00%> (ø)
smartsim/tf/__init__.py 100.00% <0.00%> (ø)

@MattToast MattToast self-requested a review January 6, 2023 23:16
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for catching and fixing this!!

@MattToast MattToast merged commit 473566f into CrayLabs:develop Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants