Grammar edits to documentation; small additions to make testing more … #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc/experiment.rst
Outdated
| determine the allocation settings for the entire batch, and the ``RunSettings`` | ||
| will determine how each individual ``Model`` instance is executed within | ||
| that batch. | ||
|
|
||
| The same example as above but tailored towards a running as a batch job | ||
| on a slurm system | ||
| This is same example as above, but tailored towards a running as a batch job |
There was a problem hiding this comment.
Should be "This is the"
doc/overview.rst
Outdated
| @@ -58,19 +58,19 @@ deploying HPC workloads alongside an in-memory database: Redis. | |||
|
|
|||
| The key features of the IL are: | |||
|
|
|||
| - An API to start, monitor, and stop HPC jobs from Python or Jupyter notebook. | |||
| - An API to start, monitor, and stop HPC jobs from a Python or Jupyter notebook. | |||
There was a problem hiding this comment.
change to "from Python or from a Jupyter notebook"
billschereriii
approved these changes
Jun 14, 2022
Codecov Report
@@ Coverage Diff @@
## develop #208 +/- ##
===========================================
+ Coverage 84.18% 84.24% +0.06%
===========================================
Files 58 59 +1
Lines 3244 3301 +57
===========================================
+ Hits 2731 2781 +50
- Misses 513 520 +7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…clear