Keydb support #180
Merged
Keydb support #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REDIS_CONF, SMARTSIM_REDIS, SMARTSIM_REDIS_URL, SMARTSIM_REDIS_BRANCH need to be set for KeyDB
Codecov Report
@@ Coverage Diff @@
## develop #180 +/- ##
===========================================
+ Coverage 81.20% 81.66% +0.46%
===========================================
Files 57 57
Lines 2910 2973 +63
===========================================
+ Hits 2363 2428 +65
+ Misses 547 545 -2
|
EricGustin
requested review from
Spartee,
al-rigazzi and
MattToast
and removed request for
Spartee and
al-rigazzi
|
Should we add tests for this code by using a new github actions job that does |
MattToast
reviewed
Apr 1, 2022
I think that seems like a great idea! If not on this PR maybe in a new ticket? |
ashao
requested changes
Apr 3, 2022
Spartee
previously requested changes
Apr 6, 2022
ashao
approved these changes
Apr 11, 2022
EricGustin
dismissed
Spartee’s stale review
Review has been addressed & was given the green light via Slack
al-rigazzi
pushed a commit
to al-rigazzi/SmartSim
that referenced
this pull request
Apr 18, 2022
keydb flag for smart build added. Users can now use KeyDB in place of Redis more easily. [ committed by @EricGustin ] [ reviewed by @MattToast @ashao @Spartee ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to use
KeyDBin place ofRedisas the database through a new--keydbflag forsmart build. This flexibility enables users to maximize their throughput if they desire.