Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataLoader fix #140

Merged
merged 5 commits into from
Feb 8, 2022
Merged

DataLoader fix #140

merged 5 commits into from
Feb 8, 2022

Conversation

al-rigazzi
Copy link
Collaborator

This PR adds fixes for some issues introduced by the DataLoaders, namely:

  • DataLoaders were incorrectly linked in docs
  • DataLoader notebooks included kernels and that made make docks fail
  • test_dataloaders.py used the standard Redis port for the orchestrators, but that port is already in use on some systems (switched to 6780)

Spartee
Spartee approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@Spartee Spartee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@al-rigazzi al-rigazzi merged commit ce90e70 into CrayLabs:develop Feb 8, 2022
@al-rigazzi al-rigazzi deleted the docks_fix branch February 8, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spartee Spartee Spartee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@al-rigazzi @Spartee