Remove numpy #132
Merged
Remove numpy #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a helper function called get_base_36_repr so that we can remove numpy from step.py Remove numpy from requirements.txt Pin requirements.dev to a specific version of numpy
EricGustin
added a commit
to EricGustin/SmartSim
that referenced
this pull request
Jan 28, 2022
* Add Build Matrix for CI (CrayLabs#130) Adds various dimensions to the CI build matrix for SmartSim. The build matrix now uses MacOS & Ubuntu, GNU8, RedisAI 1.2.3 & 1.2.5, and Python 3.7-3.9. The build matrix excludes building with RedisAI 1.2.5 when on MacOS as RedisAI temporarily removed support for MacOS in 1.2.4 and 1.2.5 [ committed by @EricGustin and @Spartee ] [ reviewed by @Spartee ] * Remove numpy as a dependency (CrayLabs#132) * Remove np from step.py and requirements Create a helper function called get_base_36_repr so that we can remove numpy from step.py Remove numpy from requirements.txt Pin requirements.dev to a specific version of numpy * Remove numpy from requirements * Remove numpy from setup [ committed by @EricGustin ] [ reviewed by @Spartee ]
MattToast
added a commit
that referenced
this pull request
Jan 28, 2022
Edits to the Tutorials section of the documentation to highlight refined api [ committed by @MattToast ] [ reviewed by @Spartee ]
al-rigazzi
pushed a commit
to al-rigazzi/SmartSim
that referenced
this pull request
Jan 31, 2022
* Remove np from step.py and requirements Create a helper function called get_base_36_repr so that we can remove numpy from step.py Remove numpy from requirements.txt Pin requirements.dev to a specific version of numpy * Remove numpy from requirements * Remove numpy from setup [ committed by @EricGustin ] [ reviewed by @Spartee ]
al-rigazzi
added a commit
to al-rigazzi/SmartSim
that referenced
this pull request
Jan 31, 2022
Edits to the Tutorials section of the documentation to highlight refined api [ committed by @MattToast ] [ reviewed by @Spartee ]
al-rigazzi
pushed a commit
to al-rigazzi/SmartSim
that referenced
this pull request
Jan 31, 2022
Edits to the Tutorials section of the documentation to highlight refined api [ committed by @MattToast ] [ reviewed by @Spartee ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the numpy dependency from SmartSim since SmartRedis already has numpy as a dependency.
step.pyneeded to be altered such that it does not use numpy to generate a unique string. numpy was also removed fromrequirements.txt,requirements-dev.txt, andsetup.py.