-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce _core internal code structure #122
Merged
Merged
Changes from 35 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
814d76d
Change SmartSim dir structure
faad1ed
Change front-end import structure
358937f
Remove TOML configuration option
c60ec17
Mirgrate the log and slurm modules
927ee73
Rename constants to status
c6eca19
Move Orchestrator functions to _core
815a7fc
CLI and build improvements
c18adf9
make style
24bbee1
clean up circular imports in config
fd0311b
Remove ill-placed SSConfigErrors
b24afb5
Adapt tests for dir change
6b45416
Fix coverage stats
d1479ac
fix smartsim.tf api
bb8ed36
make style
fbd718b
Fix .gitignore and edit CLI commands in CI
5418504
CI fixes
9d8916c
Revert to RAI 1.2.3
874001c
Correct comment in config
a85c0b4
Minor cleanup in builder class
8e737d9
Clean up output and handle CUDNN
75e03ce
Fix minor issues in logging and setup.py
536dd86
Addresses testing issues on Slurm
e06d954
fix tests
fddff85
buildenv fix
68c1acd
refactor build dep checking
829eaef
small fix to build
0e519b5
Add url checks to versioner.py
5fa8d14
Add Version_ class and RAI version support
1b40ddb
Update tf to use Version_
b221e91
Clean up install classes
690bd48
bump tf and onnx versions
9fece0f
Rebase and address review
45ded43
Branch support for RedisAI and Redis
2518655
Add ability to support future RAI versions
96c2250
make style
0b6b87d
Edit Tensorflow cmake
b9d74d0
small fix in Python build
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
include requirements.txt | ||
include setup_env.sh | ||
include Makefile | ||
graft smartsim/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,4 +6,3 @@ redis==3.5.3 | |
redis-py-cluster==2.1.3 | ||
numpy>=1.18.2 | ||
tqdm>=4.50.2 | ||
toml>=0.10.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for changing the coverage reports for the tests to be in the top level rather than in
tests/
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there was a reason and I honestly cannot remember at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping the generated files contained within the
tests
folder seems most intuitive, but if there is a reason for not doing so, then by all means, placing the coverage files at top level is okay.