Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing functions to LSFSettings API #113

Merged
merged 10 commits into from
Dec 9, 2021
Merged

Add missing functions to LSFSettings API #113

merged 10 commits into from
Dec 9, 2021

Conversation

al-rigazzi
Copy link
Collaborator

One function set_hostlist needs to pass, as this is only available (and already present) at batch level. The other two missing functions map the concept of node to that of RS, as it is the closest entity in LSF.

@al-rigazzi al-rigazzi self-assigned this Nov 22, 2021
Spartee
Spartee approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@Spartee Spartee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This should unify the interfaces nicely.

Spartee
Spartee reviewed Dec 8, 2021
View reviewed changes
Copy link
Contributor

@Spartee Spartee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple print statements left in the code

smartsim/settings/slurmSettings.py Outdated Show resolved Hide resolved
smartsim/settings/base.py Outdated Show resolved Hide resolved
@al-rigazzi al-rigazzi merged commit ab0207d into CrayLabs:develop Dec 9, 2021
@al-rigazzi al-rigazzi deleted the lsf_create_settings branch December 9, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spartee Spartee Spartee approved these changes

Assignees

@al-rigazzi al-rigazzi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@al-rigazzi @Spartee