Tweak _build_run_settings_lsf for non-nullable LSF make_mpmd argument

CrayLabs · Jun 21, 2023 · fa9db5c · fa9db5c
1 parent f6b3586
commit fa9db5c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/smartsim/database/orchestrator.py b/smartsim/database/orchestrator.py
@@ -614,12 +614,12 @@ def _build_run_settings_lsf(
 
             run_settings.set_erf_sets(erf_sets)
 
-            if erf_rs:
-                erf_rs.make_mpmd(run_settings)
-            else:
-                run_settings.make_mpmd(run_settings)
+            if not erf_rs:
                 erf_rs = run_settings
+                continue
 
+            erf_rs.make_mpmd(run_settings)
+
         kwargs["run_args"] = run_args
 
         return erf_rs

diff --git a/smartsim/settings/lsfSettings.py b/smartsim/settings/lsfSettings.py
@@ -215,8 +215,7 @@ def make_mpmd(self, settings: RunSettings) -> None:
                 "Colocated models cannot be run as a mpmd workload"
             )
 
-        if settings:
-            self.mpmd.append(settings)
+        self.mpmd.append(settings)
 
     def set_mpmd_preamble(self, preamble_lines: t.List[str]) -> None:
         """Set preamble used in ERF file. Typical lines include