fix incorrect manufacturer key in intel mockup from cray to intel #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
shunr-hpe
approved these changes
Jun 18, 2024
jwlv
approved these changes
Jun 18, 2024
jacobsalmela
added a commit
to Cray-HPE/gru
that referenced
this pull request
Jun 18, 2024
maintainability easier. This relies on two shellspec features: 1. (Parameters)[https://github.com/shellspec/shellspec?tab=readme-ov-file#parameters---parameterized-example], where you can define several params and it will execute the same tests against them 2. (Data)[https://github.com/shellspec/shellspec?tab=readme-ov-file#data---pass-data-as-stdin-to-evaluation], which passes parameters in as STDIN, which is a vital feature of gru Within the tests, I set parameters for each container running in the simulator. In some tests, I add additional ones where the output of commands vary depending upon the endpoint being targeted. There are some commented out tests, which require an updated in the emulator: Cray-HPE/csm-redfish-interface-emulator#10 Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
jacobsalmela
added a commit
to Cray-HPE/gru
that referenced
this pull request
Jun 18, 2024
maintainability easier. This relies on two shellspec features: 1. (Parameters)[https://github.com/shellspec/shellspec?tab=readme-ov-file#parameters---parameterized-example], where you can define several params and it will execute the same tests against them 2. (Data)[https://github.com/shellspec/shellspec?tab=readme-ov-file#data---pass-data-as-stdin-to-evaluation], which passes parameters in as STDIN, which is a vital feature of gru Within the tests, I set parameters for each container running in the simulator. In some tests, I add additional ones where the output of commands vary depending upon the endpoint being targeted. There are some commented out tests, which require an updated in the emulator: Cray-HPE/csm-redfish-interface-emulator#10 Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
rustydb
pushed a commit
to Cray-HPE/gru
that referenced
this pull request
Jun 28, 2024
…ke (#70) maintainability easier. This relies on two shellspec features: 1. (Parameters)[https://github.com/shellspec/shellspec?tab=readme-ov-file#parameters---parameterized-example], where you can define several params and it will execute the same tests against them 2. (Data)[https://github.com/shellspec/shellspec?tab=readme-ov-file#data---pass-data-as-stdin-to-evaluation], which passes parameters in as STDIN, which is a vital feature of gru Within the tests, I set parameters for each container running in the simulator. In some tests, I add additional ones where the output of commands vary depending upon the endpoint being targeted. There are some commented out tests, which require an updated in the emulator: Cray-HPE/csm-redfish-interface-emulator#10 Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
|
👋 Hey! Here is the image we built for you (Artifactory Link): artifactory.algol60.net/csm-docker/unstable/csm-rie:1.5.3-20240712162930.44ffd4aUse podman or docker to pull it down and inspect locally: podman pull artifactory.algol60.net/csm-docker/unstable/csm-rie:1.5.3-20240712162930.44ffd4aOr, use this script to pull the image from the build server to a dev system: Dev System Pull Script
#!/usr/bin/env bash
IMAGE=artifactory.algol60.net/csm-docker/unstable/csm-rie:1.5.3-20240712162930.44ffd4a
podman run --rm --network host \
quay.io/skopeo/stable copy \
--src-tls-verify=false \
--dest-tls-verify=false \
--dest-username "$(kubectl -n nexus get secret nexus-admin-credential -o json | jq -r '.data.username | @base64d')" \
--dest-password "$(kubectl -n nexus get secret nexus-admin-credential -o json | jq -r '.data.password | @base64d')" \
docker://$IMAGE \
docker://registry.local/$IMAGESnyk ReportComing soon Software Bill of Materialscosign download sbom artifactory.algol60.net/csm-docker/unstable/csm-rie:1.5.3-20240712162930.44ffd4a > container_image.spdxIf you don't have cosign, then you can get it here. Note: this SHA is the merge of cd97d15 and the PR base branch. Good luck and make rocket go now! 🌮 🚀 |
jacobsalmela
added a commit
to Cray-HPE/gru
that referenced
this pull request
Jul 15, 2024
disabled tests. the csm-rie:1.5.3 image incorrectly identified the Intel mockup as a "Cray". This is fixed in 1.5.4 by way of Cray-HPE/csm-redfish-interface-emulator#10 and the vendor detection by gru now works with this emulator. Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
rustydb
pushed a commit
to Cray-HPE/gru
that referenced
this pull request
Jul 15, 2024
…ble (#72) disabled tests. the csm-rie:1.5.3 image incorrectly identified the Intel mockup as a "Cray". This is fixed in 1.5.4 by way of Cray-HPE/csm-redfish-interface-emulator#10 and the vendor detection by gru now works with this emulator. Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.