Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

function for loading an hpcm config to a struct #168

Merged
merged 2 commits into from
Dec 11, 2023
Merged

function for loading an hpcm config to a struct #168

merged 2 commits into from
Dec 11, 2023

Conversation

jacobsalmela
Copy link
Collaborator

Summary and Scope

  • adds a LoadCmConfig() function, which returns an hpcm object.
  • the logic in the helper functions is far from ideal, but due in part to the loose nature of the config file itself

Risks and Mitigations

Low. Nothing using this currently except offline development of future features.

@jacobsalmela
function for loading an hpcm config to a struct
417155c 
Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
@jacobsalmela jacobsalmela self-assigned this Dec 8, 2023
@jacobsalmela jacobsalmela marked this pull request as ready for review December 8, 2023 17:11
shunr-hpe
shunr-hpe approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@shunr-hpe shunr-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Sometime in the future, in a different PR, adding test data (testdata/fixtures/) may be useful.

internal/provider/hpcm/types_hpcm_config.go Outdated Show resolved Hide resolved
@jacobsalmela
adjust ParseBool with debug and no return error, simplifying several …
b77b180 
…switch cases

Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
@jacobsalmela jacobsalmela merged commit 29a5963 into develop Dec 11, 2023
5 checks passed
@jacobsalmela jacobsalmela deleted the apparent-clover branch December 11, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shunr-hpe shunr-hpe shunr-hpe approved these changes

Assignees

@jacobsalmela jacobsalmela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobsalmela @shunr-hpe