Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove empty tests and continuity to error on commands that are not implemented #156

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

jacobsalmela
Copy link
Collaborator

Summary and Scope

  • remove empty cmd/*_test.go files, which are covered by shellspec tests
  • error on commands that are not implemented yet (cleans the slate for upcoming changes and shows the user the commands are not working yet)

Risks and Mitigations

Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
@jacobsalmela jacobsalmela marked this pull request as ready for review October 30, 2023 18:14
@jacobsalmela jacobsalmela merged commit 5c8bd7b into main Oct 30, 2023
5 checks passed
@jacobsalmela jacobsalmela deleted the settled-dark-phoenix branch October 30, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants