Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go4.org/unsafe/assume-no-moving-gc for panic on dev systems #151

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

jacobsalmela
Copy link
Collaborator

@jacobsalmela jacobsalmela commented Oct 9, 2023

Summary and Scope

  • Fixes this error seen on local dev systems when running make test
k  	github.com/Cray-HPE/cani/internal/inventory	0.161s	coverage: 21.3% of statements
panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.21 runtime. You can try updating this package by running "go get go4.org/unsafe/assume-no-moving-gc@latest". If that doesn't work and you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH="go1.21" set. Notably, if go1.21 adds a moving garbage collector, this program is unsafe to use.

goroutine 1 [running]:
go4.org/unsafe/assume-no-moving-gc.init.0()
	/root/jsalmela/cani/vendor/go4.org/unsafe/assume-no-moving-gc/untested.go:25 +0x1da
FAIL	github.com/Cray-HPE/cani/internal/provider/csm	0.011s
panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.21 runtime. You can try updating this package by running "go get go4.org/unsafe/assume-no-moving-gc@latest". If that doesn't work and you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH="go1.21" set. Notably, if go1.21 adds a moving garbage collector, this program is unsafe to use.

goroutine 1 [running]:
go4.org/unsafe/assume-no-moving-gc.init.0()
	/root/jsalmela/cani/vendor/go4.org/unsafe/assume-no-moving-gc/untested.go:25 +0x1da
FAIL	github.com/Cray-HPE/cani/internal/provider/csm/ipam	0.011s
ok  	github.com/Cray-HPE/cani/internal/provider/csm/sls	0.044s	coverage: 6.4% of statements
ok  	github.com/Cray-HPE/cani/internal/provider/csm/validate	0.156s	coverage: 50.7% of statements
ok  	github.com/Cray-HPE/cani/internal/provider/csm/validate/checks	0.020s	coverage: 40.0% of statements
ok  	github.com/Cray-HPE/cani/internal/provider/csm/validate/common	0.013s	coverage: 8.3% of statements
FAIL
make: *** [Makefile:143: unittest] Error 1

Risks and Mitigations

Low

@jacobsalmela jacobsalmela self-assigned this Oct 9, 2023
@jacobsalmela jacobsalmela marked this pull request as ready for review October 9, 2023 14:11
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
@jacobsalmela jacobsalmela merged commit df4af3f into main Oct 11, 2023
5 checks passed
@jacobsalmela jacobsalmela deleted the aware-air-walker branch October 11, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants