Replace Version Command with Cobra #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Slick. Just need to update those fixtures with the new output |
|
Oh looks like you accidentally removed some files, too like our fancy logo. |
It's not removed, it's shrunk. I shrunk it from 44kb to 16kb. |
|
I see now. I don't think we need that as part of this PR though? |
Sure, I had it as a separate commit and it got squashed in my rebase. Totally forgot about it when I made the PR. |
rustydb
force-pushed
the
rusty
branch
2 times, most recently
from
1e647a5
to
d134f3f
Compare
|
I see, you can remove that version fixture since it is not a command any more. Then just update the shellspec test |
Minify the code for printing the version by leveraging Cobra's built-in `version` parameter.
jacobsalmela
approved these changes
Sep 21, 2023
shunr-hpe
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Minify the code for printing the version by leveraging Cobra's built-in
versionparameter.This is a small contribution, it served more as an exercise for myself to get the repo cloned and to start playing with it.
Testing
When
caniis built on a tag:When
caniis built on a commit after a tag.When
caniis built with uncommitted changes in the repository folder.Risks and Mitigations