parameterize and better organize shellspec tests #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobsalmela
force-pushed
the
native-shockwave
branch
5 times, most recently
from
71877a9
to
1ff9953
Compare
jacobsalmela
requested review from
shunr-hpe and
rsjostrand-hpe
and removed request for
rsjostrand-hpe and
shunr-hpe
jacobsalmela
force-pushed
the
native-shockwave
branch
4 times, most recently
from
af2da3b
to
e8ec30f
Compare
jacobsalmela
requested review from
rsjostrand-hpe and
shunr-hpe
and removed request for
rsjostrand-hpe
jacobsalmela
force-pushed
the
native-shockwave
branch
from
e8ec30f
to
aea4d97
Compare
jacobsalmela
force-pushed
the
native-shockwave
branch
2 times, most recently
from
6234c8c
to
69a3053
Compare
shunr-hpe
approved these changes
Sep 1, 2023
jacobsalmela
force-pushed
the
native-shockwave
branch
2 times, most recently
from
c3fbef8
to
f9486dc
Compare
jacobsalmela
force-pushed
the
native-shockwave
branch
2 times, most recently
from
d9e5dc2
to
f1733af
Compare
shunr-hpe
approved these changes
Sep 5, 2023
…pting compatibility Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
jacobsalmela
force-pushed
the
native-shockwave
branch
from
f1733af
to
393d6a5
Compare
rsjostrand-hpe
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Parameters:/tmp/.cani/for all tests instead of a relative path (helps for consistency and to avoid clash with developer builds)make specto use the same script as integration and edge. this required moving the existing tests into a newspec/functionaldirectory. This also moves the script intospec/support/bin, which is a better home for itRisks and Mitigations
Low