fix for "undefined" showing up in the dashboard on the TIME SPENT widget... #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 19, 2014 10:16
…get. This commit only fixes it for the US English translation, though. To fix it for the other translations, a string named "common.year.abrv" needs to be added to the other language dashboard_*.properties files. Bug references: #88 http://support.count.ly/discussions/problems/282-some-of-ui-elements-are-undefined This commit also contains a fix for a separate minor misspelling error in the US English translation.
additionally, I made the obscure check for NaN more explicit; also made sure the callback was called in processSessionDuration even if a bad session_duration value was encountered
|
Just fixed #98 as well |
pull license updates from Countly/countly-server
…+ null in meta.d-ranges + undefined in *.ds
…n duration cleanup
* commit 'be456df37a99d78c632760fe99af0a7bba90440e': Rename LICENCE.md to LICENSE.md Make sure AGPLv3 is 1-1 same as verbatim copy Update licensing to make sure it is coherent with AGPL v3. Conflicts: LICENSE.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.... This commit only fixes it for the US English translation, though. To fix it for the other translations, a string named "common.year.abrv" needs to be added to the other language dashboard_*.properties files.
Bug references:
#88
http://support.count.ly/discussions/problems/282-some-of-ui-elements-are-undefined
This commit also contains a fix for a separate minor misspelling error in the US English translation.