[async-plugins-check] server-1248 #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frknbasaran
commented
Mar 6, 2019
frknbasaran
commented
- added async plugins check mechanism to plugins plugin.
- added async plugins check mechanism to plugins plugin.
itsiprikshit
reviewed
Mar 7, 2019
plugins/plugins/api/api.js
Outdated
| } | ||
| else { | ||
| common.returnOutput(params, 'Success'); | ||
| common.returnMessage(params, 500, "failed"); |
There was a problem hiding this comment.
I don't think a (failed) response will be sent from here because you have already sent the (started) message in line no. 27
itsiprikshit
reviewed
Mar 7, 2019
| msg.info = jQuery.i18n.map["plugins.retry"]; | ||
| msg.sticky = true; | ||
| msg.type = "error"; | ||
| else if (res.result === "error") { |
There was a problem hiding this comment.
shouldn't this be res.result == "failed" since nowhere you are returning error message from the server.
itsiprikshit
reviewed
Mar 7, 2019
| loader.hide(); | ||
| msg.title = jQuery.i18n.map["plugins.error"]; | ||
| msg.message = res; | ||
| msg.info = jQuery.i18n.map["plugins.retry"]; |
There was a problem hiding this comment.
This case is not covered, with the retry message.
- state data type changed. ({"_id":"busy"})
- added failed state type.
- multiple response problem resolved.
- uncovered cases covered on frontend.
- "not_enough_parameters" message change reverted. - that case removed from frontend too.
itsiprikshit
approved these changes
Mar 10, 2019
- code refactored. - added dynamic key=val to end of the check plugin request url.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.