Skip to content

Commit

Permalink
errors module
Browse files Browse the repository at this point in the history
  • Loading branch information
faddat committed Apr 24, 2023
1 parent 229e327 commit 4ed89fa
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 16 deletions.
11 changes: 8 additions & 3 deletions x/ibc-hooks/ibc_module.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
capabilitytypes "github.com/cosmos/cosmos-sdk/x/capability/types"

// ibc-go
clienttypes "github.com/cosmos/ibc-go/v7/modules/core/02-client/types"
channeltypes "github.com/cosmos/ibc-go/v7/modules/core/04-channel/types"
porttypes "github.com/cosmos/ibc-go/v7/modules/core/05-port/types"
ibcexported "github.com/cosmos/ibc-go/v7/modules/core/exported"
Expand Down Expand Up @@ -237,9 +238,13 @@ func (im IBCMiddleware) OnTimeoutPacket(
func (im IBCMiddleware) SendPacket(
ctx sdk.Context,
chanCap *capabilitytypes.Capability,
packet ibcexported.PacketI,
) error {
return im.ICS4Middleware.SendPacket(ctx, chanCap, packet)
sourcePort string,
sourceChannel string,
timeoutHeight clienttypes.Height,
timeoutTimestamp uint64,
data []byte,
) (uint64, error) {
return im.ICS4Middleware.SendPacket(ctx, chanCap, sourcePort, sourceChannel, timeoutHeight, timeoutTimestamp, data)
}

// WriteAcknowledgement implements the ICS4 Wrapper interface
Expand Down
26 changes: 13 additions & 13 deletions x/tokenfactory/types/msgs.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,18 +75,18 @@ func (m MsgMint) Type() string { return TypeMsgMint }
func (m MsgMint) ValidateBasic() error {
_, err := sdk.AccAddressFromBech32(m.Sender)
if err != nil {
return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid sender address (%s)", err)
return errorsmod.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid sender address (%s)", err)
}

if m.MintToAddress != "" {
_, err = sdk.AccAddressFromBech32(m.MintToAddress)
if err != nil {
return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid mint to address (%s)", err)
return errorsmod.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid mint to address (%s)", err)
}
}

if !m.Amount.IsValid() || m.Amount.Amount.Equal(sdk.ZeroInt()) {
return sdkerrors.Wrap(sdkerrors.ErrInvalidCoins, m.Amount.String())
return errorsmod.Wrap(sdkerrors.ErrInvalidCoins, m.Amount.String())
}

return nil
Expand Down Expand Up @@ -125,17 +125,17 @@ func (m MsgBurn) Type() string { return TypeMsgBurn }
func (m MsgBurn) ValidateBasic() error {
_, err := sdk.AccAddressFromBech32(m.Sender)
if err != nil {
return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid sender address (%s)", err)
return errorsmod.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid sender address (%s)", err)
}

if !m.Amount.IsValid() || m.Amount.Amount.Equal(sdk.ZeroInt()) {
return sdkerrors.Wrap(sdkerrors.ErrInvalidCoins, m.Amount.String())
return errorsmod.Wrap(sdkerrors.ErrInvalidCoins, m.Amount.String())
}

if m.BurnFromAddress != "" {
_, err = sdk.AccAddressFromBech32(m.BurnFromAddress)
if err != nil {
return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid burn from address (%s)", err)
return errorsmod.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid burn from address (%s)", err)
}
}

Expand Down Expand Up @@ -168,20 +168,20 @@ func (m MsgForceTransfer) Type() string { return TypeMsgForceTransfer }
func (m MsgForceTransfer) ValidateBasic() error {
_, err := sdk.AccAddressFromBech32(m.Sender)
if err != nil {
return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid sender address (%s)", err)
return errorsmod.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid sender address (%s)", err)
}

_, err = sdk.AccAddressFromBech32(m.TransferFromAddress)
if err != nil {
return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid from address (%s)", err)
return errorsmod.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid from address (%s)", err)
}
_, err = sdk.AccAddressFromBech32(m.TransferToAddress)
if err != nil {
return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid to address (%s)", err)
return errorsmod.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid to address (%s)", err)
}

if !m.Amount.IsValid() {
return sdkerrors.Wrap(sdkerrors.ErrInvalidCoins, m.Amount.String())
return errorsmod.Wrap(sdkerrors.ErrInvalidCoins, m.Amount.String())
}

return nil
Expand Down Expand Up @@ -212,12 +212,12 @@ func (m MsgChangeAdmin) Type() string { return TypeMsgChangeAdmin }
func (m MsgChangeAdmin) ValidateBasic() error {
_, err := sdk.AccAddressFromBech32(m.Sender)
if err != nil {
return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid sender address (%s)", err)
return errorsmod.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid sender address (%s)", err)
}

_, err = sdk.AccAddressFromBech32(m.NewAdmin)
if err != nil {
return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid address (%s)", err)
return errorsmod.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid address (%s)", err)
}

_, _, err = DeconstructDenom(m.Denom)
Expand Down Expand Up @@ -252,7 +252,7 @@ func (m MsgSetDenomMetadata) Type() string { return TypeMsgSetDenomMetadata }
func (m MsgSetDenomMetadata) ValidateBasic() error {
_, err := sdk.AccAddressFromBech32(m.Sender)
if err != nil {
return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid sender address (%s)", err)
return errorsmod.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid sender address (%s)", err)
}

err = m.Metadata.Validate()
Expand Down

0 comments on commit 4ed89fa

Please sign in to comment.