Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tested python versions #61

Merged
merged 7 commits into from
Jan 23, 2024
Merged

Update tested python versions #61

merged 7 commits into from
Jan 23, 2024

Conversation

rstoneback
Copy link
Collaborator

@rstoneback rstoneback commented Jan 22, 2024

Description

Addresses #(issue)

Updates Python versions tested as well as address security update in readthedocs

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Online testing

Checklist:

  • Make sure you are merging into the develop (not master) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

@rstoneback
Copy link
Collaborator Author

Hey @jklenzing do you have any ideas on why coveralls is rejecting some of the coverage info, but not others? It somehow got worse when I went from testing 4 python versions down to 3 :(

Searching on the web the fixes are to include things like run: coveralls --rcfile=setup.cfg --service=github which is already in main.yml for workflows.....

@rstoneback
Copy link
Collaborator Author

@rstoneback rstoneback marked this pull request as draft January 23, 2024 02:10
@rstoneback
Copy link
Collaborator Author

Thanks @jklenzing , the info in pysat saved the day once again 👍

@rstoneback rstoneback marked this pull request as ready for review January 23, 2024 02:17
@rstoneback rstoneback merged commit e322c7a into develop Jan 23, 2024
12 checks passed
@rstoneback rstoneback deleted the fix_testing_versions branch January 23, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant