Change TextField's visibility icon behaviour in order to match more Android EditText's one #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemisia-absynthium
commented
Nov 22, 2017
•
artemisia-absynthium
commented
- Add visibility off material icon, toggle animation between visibility on and off icons and ripple, much more similar to Android's original EditText
- Remove font change because it would eliminate any custom font when changing visibility the first time
…ty on and off icons and ripple, much more similar to Android's original EditText * remove font change because it would eliminate any custom font when changing visibility the first time
artemisia-absynthium
changed the title
daniel-jonathan
approved these changes
Nov 22, 2017
| @@ -350,9 +350,9 @@ open class TextField: UITextField { | |||
| return | |||
| } | |||
|
|
|||
| visibilityIconButton = IconButton(image: Icon.visibility, tintColor: placeholderNormalColor.withAlphaComponent(isSecureTextEntry ? 0.38 : 0.54)) | |||
| visibilityIconButton = isSecureTextEntry ? IconButton(image: Icon.visibility, tintColor: placeholderNormalColor.withAlphaComponent(0.54)) : IconButton(image: Icon.visibilityOff, tintColor: placeholderNormalColor.withAlphaComponent(0.54)) | |||
There was a problem hiding this comment.
As a note, I updated this line to:
IconButton(image: isSecureTextEntry ? Icon.visibility : Icon.visibilityOff, tintColor: placeholderNormalColor.withAlphaComponent(0.54))less code :)
There was a problem hiding this comment.
Oh! You're totally right!! Thanks a lot! :)
| } | ||
|
|
||
| visibilityIconButton?.tintColor = visibilityIconButton?.tintColor.withAlphaComponent(isSecureTextEntry ? 0.38 : 0.54) | ||
| UIView.transition(with: (visibilityIconButton?.imageView)!, |
There was a problem hiding this comment.
One more note, if the developer sets the tint color of the button, it will be changed here to the placeholder color. So this should handle that:
animations: { [weak self] in
guard let `self` = self else {
return
}
guard let v = self.visibilityIconButton else {
return
}
v.image = self.isSecureTextEntry ? Icon.visibilityOff?.tint(with: v.tintColor.withAlphaComponent(0.54)) : Icon.visibility?.tint(with: v.tintColor.withAlphaComponent(0.54))
},There was a problem hiding this comment.
You're right again! I'm sorry, I'm not much used to coding for public libraries ^^'
Anyway, I think that the two icons are inverted in this snippet.
There was a problem hiding this comment.
You did great! It is my responsibility to massage it into the framework. Keep it coming ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.