Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Layout relations #1236

Merged
merged 2 commits into from
May 24, 2019
Merged

Added Layout relations #1236

merged 2 commits into from
May 24, 2019

Conversation

OrkhanAlikhanov
Copy link
Contributor

Implemented feature requested in #1220

Now, relation can be passed as last parameter (>=, <= or ==)

view.layout(child)
  .width(10, >=)
  .right(view2.anchor.left, 0, <=)
  .left(10, >=)

@daniel-jonathan daniel-jonathan self-requested a review May 22, 2019 21:08
daniel-jonathan
daniel-jonathan reviewed May 22, 2019
View reviewed changes
Copy link
Member

@daniel-jonathan daniel-jonathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! I added a question in there about LayoutRelation naming.

Sources/iOS/Layout/Layout.swift Show resolved Hide resolved
Sources/iOS/Layout/LayoutConstraint.swift Show resolved Hide resolved
@daniel-jonathan daniel-jonathan merged commit a944d77 into CosmicMind:development May 24, 2019
@OrkhanAlikhanov OrkhanAlikhanov mentioned this pull request Sep 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-jonathan daniel-jonathan daniel-jonathan left review comments

Assignees

@OrkhanAlikhanov OrkhanAlikhanov

Labels
feature request material
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrkhanAlikhanov @daniel-jonathan