-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: integrate libwasmvm into Go code and test Go project on Windows #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aee436c
to
13841ef
Compare
b49012f
to
bd0a56e
Compare
393036f
to
3557f9f
Compare
3eb19b8
to
1010430
Compare
Merged
e2fb098
to
94d9840
Compare
94d9840
to
425cc11
Compare
No windows support planned for the time being |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up work of #338. Thank you very much for pushing that and showing how it can be done. I took a lot from over there.
In the meantime we pulled out a bunch of blockers and fixed them separately:
assert_approx_eq
macro for nicer testing #352 and Copy assert_approx_eq to cosmwasm_std::testing cosmwasm#1417 make the test code more resilient to OS specific nuances, which helps this repo in other places as well (e.g. Intel vs. M1 CPU on Mac)Closes #371