Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused NegotiateAppVersion ibc callback #879

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Remove unused NegotiateAppVersion ibc callback #879

merged 1 commit into from
Jun 3, 2022

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jun 1, 2022

Now applications will perform this version negotiation during the channel handshake, thus removing the need for NegotiateAppVersion.

https://github.com/cosmos/ibc-go/blob/main/docs/migrations/v2-to-v3.md#negotiateappversion-removed-from-ibcmodule-interface

@alpe alpe requested a review from ethanfrey June 1, 2022 10:12
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #879 (f6ca36f) into main (4525d51) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
+ Coverage   59.14%   59.19%   +0.05%     
==========================================
  Files          51       51              
  Lines        6198     6196       -2     
==========================================
+ Hits         3666     3668       +2     
+ Misses       2265     2262       -3     
+ Partials      267      266       -1     
Impacted Files Coverage Δ
x/wasm/ibc.go 69.51% <ø> (+0.83%) ⬆️
x/wasm/keeper/keeper.go 88.57% <0.00%> (+0.33%) ⬆️

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@alpe alpe merged commit 775f1cc into main Jun 3, 2022
@alpe alpe deleted the ibc_cleanup branch June 3, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants