Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom codec with sdk codec #760

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Replace custom codec with sdk codec #760

merged 1 commit into from
Feb 21, 2022

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Feb 21, 2022

Resolves #749

@alpe alpe requested a review from pinosu February 21, 2022 09:34
ethanfrey
ethanfrey approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The simplest fix.

Ideally the sdk uses this (IMO better) codec or makes it more extensible.
The code is in git history in any case.

@alpe alpe merged commit 95d58b8 into master Feb 21, 2022
@alpe alpe deleted the 749-client-encoding branch February 21, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

@pinosu pinosu Awaiting requested review from pinosu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom client codec crashes with Rosetta enabled
2 participants
@alpe @ethanfrey