Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decorator options #598

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Add decorator options #598

merged 1 commit into from
Sep 1, 2021

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Aug 30, 2021

I played today with the query and message handler extension points and they are pretty hard to extend.
They likely require a keeper instance. With the decorator keeper options this can be simplified.
I have modified one of our tests to show the old vs new setup.

@alpe alpe requested review from ethanfrey and husio August 30, 2021 13:03
Copy link
Contributor

@husio husio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🥪

Please keep in mind that I don't get all the design implications yet.

x/wasm/keeper/options.go Show resolved Hide resolved
@alpe alpe merged commit 4e242e0 into master Sep 1, 2021
@alpe alpe deleted the decorators branch September 1, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants