-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Charge gas for custom event attributes and messages #539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start.
Added some comments.
What do you think of a price per attribute + price per byte (like iavl storage access)?
Codecov Report
@@ Coverage Diff @@
## master #539 +/- ##
==========================================
+ Coverage 58.51% 58.67% +0.15%
==========================================
Files 43 44 +1
Lines 4532 4554 +22
==========================================
+ Hits 2652 2672 +20
- Misses 1662 1663 +1
- Partials 218 219 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. I would just like Simon to review the proper max value
Features