Update to sdk v0.38.0 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 63.21% 63.39% +0.18%
==========================================
Files 14 14
Lines 1101 1101
==========================================
+ Hits 696 698 +2
+ Misses 339 337 -2
Partials 66 66
Continue to review full report at Codecov.
|
ethanfrey
approved these changes
Jan 24, 2020
| @@ -39,7 +39,6 @@ func main() { | |||
| config.SetBech32PrefixForAccount(sdk.Bech32PrefixAccAddr, sdk.Bech32PrefixAccPub) | |||
| config.SetBech32PrefixForValidator(sdk.Bech32PrefixValAddr, sdk.Bech32PrefixValPub) | |||
| config.SetBech32PrefixForConsensusNode(sdk.Bech32PrefixConsAddr, sdk.Bech32PrefixConsPub) | |||
| config.SetKeyringServiceName("wasmd") | |||
There was a problem hiding this comment.
Interesting that you removed this, but I guess this functionality got removed from the sdk. Huh.
I tried it out and it does use a different keyring than before. But now it is called wasm rather than wasmd. Wondering where the name comes from. Guess this is not your work, just curious.
Thanks for making the fix.
There was a problem hiding this comment.
It comes from the App Name I believe
GNaD13
pushed a commit
to GNaD13/wasmd
that referenced
this pull request
Dec 19, 2024
Fix: Change sims for legacy proposal (govv1beta1) to new type (govv1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added relevant
godoccomments.Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdRe-reviewed
Files changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)